Update Skeleton to Symfony 7.2 #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/symfony-7-2-update
branch
from
2b37f86 to
f6f4435
Compare
Comment on lines
+4
to
+11
| # csrf_protection: | ||
| # token_id: submit | ||
| # | ||
| # csrf_protection: | ||
| # stateless_token_ids: | ||
| # - submit | ||
| # - authenticate | ||
| # - logout |
There was a problem hiding this comment.
This is enabled by default in Symfony Skeleton. Not sure if we should enable it or not.
We need to test sulu/form-bundle before enabling it. Also updates its csrf protection documentation. So I will current case keep it outcommented.
| @@ -1,8 +1,7 @@ | |||
| # see https://symfony.com/doc/current/reference/configuration/framework.html | |||
| framework: | |||
| secret: '%env(APP_SECRET)%' | |||
| #csrf_protection: true | |||
There was a problem hiding this comment.
was moved to own csrf.yaml file
alexander-schranz
force-pushed
the
feature/symfony-7-2-update
branch
from
2933027 to
fc414cd
Compare
alexander-schranz
force-pushed
the
feature/symfony-7-2-update
branch
from
fc414cd to
115604d
Compare
Prokyonn
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Update to Symfony 7.2.
Why?
Try reproduce sulu/sulu#7696. But looks like if all is correctly done and recipes update conflicts correctly resolve Sulu works like expected.
So looks like we can safely update as the error is unrelated.